Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs issue autogeneration to point to new docs repo #5219

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

mattrunyon
Copy link
Contributor

@margaretkennedy asked for the auto generated docs issues to be opened in the new docs repo. I put DocumentationNeeded label just as a test. I tested in a personal organization.

@devinrsmith If you want to update the DOCS_ISSUES_PAT secret to use a fine grained PAT, you can set it to the following settings

Only select repos
deephaven-core
deephaven-docs-community

Repo permissions
Issues Read/Write (opening the issue)
Pull requests Read/write (commenting on the PR)

margaretkennedy
margaretkennedy previously approved these changes Mar 5, 2024
@devinrsmith
Copy link
Member

It's a bit unfortunate, GH still labels "Fine-grained tokens" as "Beta". The one feature it is missing that would be relevant here is to set "no expiration". I know that's not best practice, but it's convenient. Even better would be if we could set permissions on the workflows / GH action context itself instead of having it tied to a "personal access token". I'm just as happy to leave it for now; I think we should want to update all our PATs at the same point in time in the future.

@mattrunyon mattrunyon merged commit b01510b into deephaven:main Mar 5, 2024
18 of 19 checks passed
@mattrunyon mattrunyon deleted the docs-auto-issue-repo-change branch March 5, 2024 22:20
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2024
@deephaven-internal
Copy link
Contributor

Labels indicate documentation is required. Issues for documentation have been opened:

Community: deephaven/deephaven-docs-community#169

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants